Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Added custom_key_store_id, bump version of AWS provider to 4.x #23

Merged
merged 1 commit into from
Sep 5, 2023
Merged

feat!: Added custom_key_store_id, bump version of AWS provider to 4.x #23

merged 1 commit into from
Sep 5, 2023

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Sep 4, 2023 •
edited by antonbabenko
Loading

Description

Fixes #21

Motivation and Context

Fixes #21
hashicorp/terraform-provider-aws#16491

Breaking Changes

Bumped aws provider version to >=4.33 and terraform >v1.0.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko changed the title feat: Add custom_key_store_id feat!: Added custom_key_store_id, bump version of AWS provider to 4.x Sep 5, 2023
@antonbabenko antonbabenko merged commit beb5667 into terraform-aws-modules:master Sep 5, 2023
antonbabenko pushed a commit that referenced this pull request Sep 5, 2023
@semantic-release-bot
chore(release): version 2.0.0 [skip ci]
a84cb70 
## [2.0.0](v1.5.0...v2.0.0) (2023-09-05)

### ⚠ BREAKING CHANGES

* Added `custom_key_store_id`, bump version of AWS provider to 4.x (#23)

### Features

* Added `custom_key_store_id`, bump version of AWS provider to 4.x ([#23](#23)) ([beb5667](beb5667))
@antonbabenko
Copy link
Member

This PR is included in version 2.0.0 🎉

@magreenbaum magreenbaum deleted the feat/add_custom_key_store_id branch September 5, 2023 11:43
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to use custom key store (cloudhsm)
2 participants
@magreenbaum @antonbabenko